Added Nerf in the Wild to Nerfacto #3574
Open
+46
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the correct transient rendering and loss from NerfW based on the semantic-nerfw and https://github.com/kwea123/nerf_pl/tree/nerfw code bases.
You can run the training using the following command:
ns-train nerfacto --pipeline.model.use_transient_embedding True --pipeline.model.hidden_dim_transient 128 --pipeline.model.transient_embed_dim 16 --data [data-path]I didn't get to test all cases (normal rendering, etc)
But the transient components seem to be working correctly now.
Before with semantic nerf implementation:
After the change:
Let me know if I should add the fix to semantic nerf as well.