Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification prop refactor #283

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Notification prop refactor #283

merged 3 commits into from
Sep 12, 2024

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Sep 12, 2024

Should have no API changes, goal is to be slightly less repetitive + more consistent with #280.

ginazhouhuiwu
ginazhouhuiwu approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@ginazhouhuiwu ginazhouhuiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Thank you for cleaning it up! 😄

@brentyi brentyi merged commit 652c8ab into main Sep 12, 2024
9 checks passed
@brentyi brentyi deleted the brent/notif_refactor branch September 12, 2024 23:12
@brentyi brentyi mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ginazhouhuiwu ginazhouhuiwu ginazhouhuiwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentyi @ginazhouhuiwu