-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New UI main page #98
New UI main page #98
Conversation
@@ -0,0 +1,179 @@ | |||
/*! | |||
Lato font. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied in the entire lato.scss
file, made the necessary changes for this project, and commented out the fonts we aren't using. As much as I try to avoid committing commented code, this should be at low-risk of changing and sets the next developer up to only have to uncomment the code if we add another lato font to the project (like italics).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty okay with it. There's not a lack of space in these devices, so this is fine.
@@ -0,0 +1,87 @@ | |||
/* LiveView specific classes for your customizations */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep the boilerplate live view styling around, or should I delete it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to keep or modify the styling for the feedback, phx-click-loading, phx-disconnected, and alert classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks!
7a5726f
to
878fc5e
Compare
I'm going to hold off on updating this branch to master until #97 is in to avoid merge commit spam. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks great!
I left a couple tiny comments, nothing blocking.
There's something in the styling that shifts the keypad to the right when it renders the configuration section. I don't know if that's intentional, but it's worth noting to fix for later.
@@ -0,0 +1,179 @@ | |||
/*! | |||
Lato font. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty okay with it. There's not a lack of space in these devices, so this is fine.
Co-authored-by: Jesse Van Volkinburg <42327429+vanvoljg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Resolves #78
Adjustments & Notes
xebow.local
, and if the connection were down there would be no way to get to the UI to see this information.Screenshot