Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify installation instructions for custom_updater #26

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Simplify installation instructions for custom_updater #26

merged 2 commits into from
Feb 21, 2019

Conversation

ludeeus
Copy link
Contributor

@ludeeus ludeeus commented Feb 19, 2019

@ludeeus ludeeus marked this pull request as ready for review February 19, 2019 15:15
@nervetattoo
Copy link
Owner

One question @ludeeus . The single-card in tracker.json requirement for this ... do you consider that a missing feature that you intend to fix? Based on #22 it seems like the editor should be its own card, meaning I'm likely to end up with 2 entries in tracker.json and suddenly break updates for people using this (way better) install method.

@ludeeus
Copy link
Contributor Author

ludeeus commented Feb 21, 2019

Should not be an issue as long as the name of it will be simple-thermostat-editor.
Near the bottom of the link I added you will see that it tries to fetch 3 files from the repo.

When all that is taken care of, it will start to download the card file(s). It will try to get these:

- custom-card-name.js
- custom-card-name.lib.js
 -custom-card-name-editor.js

I think that should hold for most cards, so I'm currently not considering it as a missing feature :)

@nervetattoo
Copy link
Owner

I did miss that part yes! That makes it clear :) I think this is a fair convention to expect.

@nervetattoo nervetattoo merged commit 63c8103 into nervetattoo:master Feb 21, 2019
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants