Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ᚬmaster] Add more statistic charts #428

Merged
merged 22 commits into from
Dec 11, 2019
Merged

[ᚬmaster] Add more statistic charts #428

merged 22 commits into from
Dec 11, 2019

Conversation

duanyytop
Copy link
Contributor

@duanyytop duanyytop commented Dec 4, 2019 •
edited
Loading

  • Add statistic data structure and http service
  • Create single page for every statistic data
    • Transaction count chart
    • Addresses count
    • Total dao deposit
    • Diffculty and Hash Rate
    • Difficulty and Uncle Rate
    • Cell count (Live Cell and Dead Cell)
  • Create chart cards page
    • render charts
    • add loading for charts with cards

@nervos-bot nervos-bot bot changed the title Add more statistic charts [ᚬmaster] Add more statistic charts Dec 4, 2019
@duanyytop duanyytop marked this pull request as ready for review December 6, 2019 08:08
Keith-CY
Keith-CY reviewed Dec 8, 2019
View reviewed changes
src/pages/StatisticsChart/CellCount.tsx Outdated
@@ -88,6 +88,7 @@ const getOption = (statisticCellCounts: State.StatisticCellCount[], isThumbnail
{
name: i18n.t('statistic.live_cell'),
type: 'line',
stack: '总量',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the chart displayed only in Chinese?

Copy link
Contributor Author

@duanyytop duanyytop Dec 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Echarts example gave me a mistake and this value is just same between series of chart option.

I updated to cell_count to understand more easily. da9b614

@duanyytop duanyytop requested a review from Keith-CY December 8, 2019 14:57
@Keith-CY
Copy link
Collaborator

Keith-CY commented Dec 9, 2019

Please resolve the conflict.

@duanyytop
Copy link
Contributor Author

Please resolve the conflict.

Fixed.

shaojunda
shaojunda reviewed Dec 9, 2019
View reviewed changes
Copy link
Contributor

@shaojunda shaojunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wait for the backend code to be deployed

@duanyytop duanyytop merged commit 32ad268 into master Dec 11, 2019
@duanyytop duanyytop deleted the more-charts branch December 11, 2019 01:00
Keith-CY pushed a commit that referenced this pull request Dec 18, 2024
@devchenyan
feat: cell_deps api (#428)
b32833f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaojunda shaojunda shaojunda left review comments

@Keith-CY Keith-CY Keith-CY approved these changes

@CipherWang CipherWang Awaiting requested review from CipherWang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duanyytop @Keith-CY @shaojunda