Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: README typo scrip_type -> script_type #65

Merged
merged 2 commits into from
Mar 3, 2023
Merged

fix: README typo scrip_type -> script_type #65

merged 2 commits into from
Mar 3, 2023

Conversation

LiRiu
Copy link
Contributor

@LiRiu LiRiu commented Mar 1, 2023

fix typo in README.md scrip_type -> script_type
and lint README.md

@LiRiu LiRiu changed the title fix(README) fix typo scrip_type -> script_type fix: README typo scrip_type -> script_type Mar 1, 2023
eval-exec
eval-exec reviewed Mar 1, 2023
View reviewed changes
README.md Outdated
Comment on lines 726 to 727
["input", "0x0"],
["output", "0x1"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to retain the indentation and new line in there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@quake quake merged commit 174a89f into nervosnetwork:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec left review comments

@quake quake quake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiRiu @quake @eval-exec