Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve relay v3 bug #189

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

quake
Copy link
Member

@quake quake commented Feb 1, 2024

resolve #188

@quake quake requested a review from chaoticlonghair February 1, 2024 04:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (e5eb012) 72.22% compared to head (6c88eb6) 71.77%.

Files Patch % Lines
src/protocols/relayer.rs 0.00% 33 Missing ⚠️
src/subcmds.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #189      +/-   ##
===========================================
- Coverage    72.22%   71.77%   -0.46%     
===========================================
  Files           25       25              
  Lines         6658     6700      +42     
===========================================
  Hits          4809     4809              
- Misses        1849     1891      +42     
Flag Coverage Δ
unittests 71.77% <0.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chaoticlonghair
chaoticlonghair previously approved these changes Feb 1, 2024
@quake quake merged commit 086581d into nervosnetwork:develop Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the transaction did not broadcast properly
3 participants