refactor: Remove initializers from Memory trait #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different memory trait impls might require different ways of initializing,what's more, having initializers in Memory trait would prevent us from writing `Box<dyn Memory<u64>>`. What we really need here, is a reset memory function. This changes uses `reset_memory` to replace initializers in Memory trait.
This preserves the semantics of original code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different memory trait impls might require different ways of initializing,what's more, having initializers in Memory trait would prevent us from writing
Box<dyn Memory<u64>>. What we really need here, is a reset memory function. This changes usesreset_memoryto replace initializers in Memory trait.