feat: avoid explosion of disordering blocks based on BLOCK_DOWNLOAD_WINDOW #2002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "sync" protocol downloads different blocks from multiple peers. In the case of different download speeds between peers, that will cause some disordering blocks backlog in
orphan_pool
.To avoid the explosion of disordering blocks, we limit the download speed based on
BLOCK_DOWNLOAD_WINDOW
:BLOCK_DOWNLOAD_WINDOW
should be good enough to limit the disordering blocks but meanwhile, tolerate download speed differences between peers. I am not sure whether1024 * 8
is good enough, but it is a safe value in my opinion.