Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump rust toolchain from 1.41.0 to 1.45.2 #2170

Merged

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Jul 20, 2020

driftluo
driftluo previously approved these changes Jul 20, 2020
quake
quake previously approved these changes Jul 20, 2020
Copy link
Member

@quake quake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rpc/src/error.rs Outdated Show resolved Hide resolved
quake
quake previously approved these changes Jul 20, 2020
driftluo
driftluo previously approved these changes Jul 20, 2020
Copy link
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold until Aug 8th

@zhangsoledad
Copy link
Member

rust-lang/rust#74739

@doitian
Copy link
Member

doitian commented Jul 27, 2020

Better upgrade to 1.45.1

@yangby-cryptape yangby-cryptape added the s:hold Status: Put this issue on hold. label Jul 28, 2020
@driftluo
Copy link
Collaborator

wait rust-lang/rust#74958

@yangby-cryptape yangby-cryptape changed the title chore: bump rust toolchain from 1.41.0 to 1.45.0 chore: bump rust toolchain from 1.41.0 to 1.45.2 Aug 5, 2020
@doitian
Copy link
Member

doitian commented Aug 5, 2020

CKB Docker Builder PR-3 unblocked

@yangby-cryptape yangby-cryptape dismissed stale reviews from driftluo and quake via 33a759e August 7, 2020 13:32
@yangby-cryptape yangby-cryptape removed the s:hold Status: Put this issue on hold. label Aug 7, 2020
@yangby-cryptape
Copy link
Collaborator Author

bors r=quake,driftluo

bors bot added a commit that referenced this pull request Aug 10, 2020
2170: chore: bump rust toolchain from 1.41.0 to 1.45.2 r=quake,driftluo a=yangby-cryptape

- Fix clippy warings, except [`clippy::mutable_key_type`].
- Allow [`clippy::mutable_key_type`].

[`clippy::mutable_key_type`]: https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type

Co-authored-by: Boyu Yang <yangby@cryptape.com>
@doitian
Copy link
Member

doitian commented Aug 10, 2020

Approved. The target release is v0.36.0

@yangby-cryptape
Copy link
Collaborator Author

bors r=quake,driftluo,doitian

@bors
Copy link
Contributor

bors bot commented Aug 10, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 9bee7ba into nervosnetwork:develop Aug 10, 2020
@yangby-cryptape yangby-cryptape deleted the pr/upgrade-rust-toolchain branch September 11, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants