feat: advance last_common_header even the peer is worse than us #2212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last_common_header
is like a cursor of block-sync mechanism between the local node and remote peers. The local node only fetches blocks from peers who have a better chain. It means it is not necessary to timely advance thelast_common_header
of peers whose chain is worse than the local.However, #2196 adds
last_common_header
to RPCget_peers
. It expects that the returnedlast_common_header
to provide a more realistic picture. Hence I create this PR, timely advance thelast_common_header
of peers even their chains are worse than the local.