Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split logger config and service #2220

Merged
merged 1 commit into from
Aug 11, 2020
Merged

refactor: split logger config and service #2220

merged 1 commit into from
Aug 11, 2020

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Aug 11, 2020 •
edited
Loading

Originally posted by @doitian in #2199 (comment)

  • Split logger config and service.
  • Let ckb-app-config only be dependent on ckb-logger-config.
  • Move the function which checks identifier into ckb-util.

@yangby-cryptape yangby-cryptape requested a review from a team August 11, 2020 04:36
@yangby-cryptape
Copy link
Collaborator Author

CI is blocked, "force-push" to re-run it.

@yangby-cryptape yangby-cryptape mentioned this pull request Aug 11, 2020
Merged
@keroro520
Copy link
Contributor

bors r=TheWaWaR,doitian,keroro520

@bors
Copy link
Contributor

bors bot commented Aug 11, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit ef21b48 into nervosnetwork:develop Aug 11, 2020
@yangby-cryptape yangby-cryptape deleted the pr/refactor-logger branch September 11, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake left review comments

@keroro520 keroro520 keroro520 approved these changes

@TheWaWaR TheWaWaR TheWaWaR approved these changes

@doitian doitian doitian approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yangby-cryptape @keroro520 @quake @doitian @TheWaWaR