Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rewrite ping #2229

Merged
merged 2 commits into from
Sep 1, 2020
Merged

refactor: Rewrite ping #2229

merged 2 commits into from
Sep 1, 2020

Conversation

driftluo
Copy link
Collaborator

  1. rewrite ping
  2. remove last_ping_time

@driftluo driftluo requested review from a team and TheWaWaR August 14, 2020 05:28
@driftluo driftluo force-pushed the rewrite-ping branch 2 times, most recently from 8cc0693 to 3d220e0 Compare August 14, 2020 06:33
@doitian
Copy link
Member

doitian commented Aug 17, 2020

What's the motivation to rewrite?

@driftluo
Copy link
Collaborator Author

What's the motivation to rewrite?

Reduce unnecessary consumption

quake
quake previously approved these changes Aug 17, 2020
quake
quake previously approved these changes Aug 31, 2020
@driftluo
Copy link
Collaborator Author

driftluo commented Sep 1, 2020

bors r=doitian, yangby-cryptape

@bors
Copy link
Contributor

bors bot commented Sep 1, 2020

Build succeeded:

@bors bors bot merged commit 6c51089 into nervosnetwork:develop Sep 1, 2020
@driftluo driftluo deleted the rewrite-ping branch September 1, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants