feat: support to control memory usage for header map #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
requested review from
doitian,
keroro520,
quake and
zhangsoledad
as code owners
quake
requested changes
Aug 24, 2020
ckb-bin/src/subcommand/run.rs
Outdated
| .header_map | ||
| .as_ref() | ||
| .cloned() | ||
| .unwrap_or_else(Default::default), |
There was a problem hiding this comment.
Suggested change
| .unwrap_or_else(Default::default), | |
| .unwrap_or_default, |
shared/src/shared.rs
Outdated
| @@ -200,6 +205,10 @@ impl Shared { | |||
| pub fn store(&self) -> &ChainDB { | |||
| &self.store | |||
| } | |||
|
|
|||
| pub fn header_map_config(&self) -> &HeaderMapConfig { | |||
There was a problem hiding this comment.
I don't think we need a fn to get header_map_config here, the config should be passed to Shared::init directly like other config objects
yangby-cryptape
force-pushed
the
pr/control-header-map-limits
branch
from
7aa5a2d to
a7e8cbd
Compare
yangby-cryptape
force-pushed
the
pr/control-header-map-limits
branch
from
a7e8cbd to
7e387dc
Compare
quake
approved these changes
Aug 29, 2020
keroro520
approved these changes
Aug 29, 2020
|
bors r=quake,keroro520 |
|
bors r=quake,keroro520 |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.