fix: resolve network background service cleanup issue when rpc tcp server is on #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
changed the title
driftluo
approved these changes
Sep 17, 2020
TheWaWaR
approved these changes
Sep 17, 2020
yangby-cryptape
approved these changes
Sep 18, 2020
doitian
approved these changes
Sep 21, 2020
|
bors r=doitian,TheWaWaR,driftluo,yangby-cryptape |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network background services (peer store dump, etc) can not be dropped automatically when rpc tcp service is on, this PR drop the rpc_server explicitly to resolve this issue. (I don't know the root reason, but it works)