feat: prepend the binary version to BlockAssemblerConfig message

[quake]

No description provided.

[quake]

I don't want the user to set this parameter during init, if they want to remove the message_prefix, they need to edit ckb.toml and set it to "0x".

How about adding a commented out line in the generated ckb.toml file?

# A message prefix used to identify the miner client, miner can disable this prefix by setting it to empty hex string: "0x".
# messsage_prefix = "0x"

[yangby-cryptape]

Looks good.

Only one trivial issue: should we add a separator?

If a user set the message as follow:

message = "Mined by Xxx."

The real message will be "ckb 0.44.0-pre (337b520 2021-07-12)Mined by Xxx.".

        let message = config.message_prefix.as_ref().map_or_else(
            || config.message.as_bytes().pack(),
            |prefix| {
                [prefix.as_bytes(), config.message.as_bytes()]
                    .concat()
                    .pack()
            },
        );

So maybe he/she should set the message as follow to make the message more readable with default prefix:

message = "; Mined by Xxx."

[keroro520]

I don't want the user to set this parameter during init, if they want to remove the message_prefix, they need to edit ckb.toml and set it to "0x".

How about adding a commented out line in the generated ckb.toml file?

# A message prefix used to identify the miner client, miner can disable this prefix by setting it to empty hex string: "0x".
# messsage_prefix = "0x"

The name message_prefix is too general. Its purpose is to attach the binary version to cellbase witnesses. It is difficult for me to connect the field's name to its purpose.

cellbase.lock may want the extra message to appear on the suffix. Their custom block_assembler.message is 1st.

[keroro520]

I don't want the user to set this parameter during init, if they want to remove the message_prefix, they need to edit ckb.toml and set it to "0x".
How about adding a commented out line in the generated ckb.toml file?

# A message prefix used to identify the miner client, miner can disable this prefix by setting it to empty hex string: "0x".
# messsage_prefix = "0x"

The name message_prefix is too general. Its purpose is to attach the binary version to cellbase witnesses. It is difficult for me to connect the field's name to its purpose.

cellbase.lock may want the extra message to appear on the suffix. Their custom block_assembler.message is 1st.

What about this

block_assembler.message_options: {
  embed_client_version: bool, // default is true
}

[zhangsoledad]

I don't want the user to set this parameter during init, if they want to remove the message_prefix, they need to edit ckb.toml and set it to "0x".
How about adding a commented out line in the generated ckb.toml file?

# A message prefix used to identify the miner client, miner can disable this prefix by setting it to empty hex string: "0x".
# messsage_prefix = "0x"

The name message_prefix is too general. Its purpose is to attach the binary version to cellbase witnesses. It is difficult for me to connect the field's name to its purpose.
cellbase.lock may want the extra message to appear on the suffix. Their custom block_assembler.message is 1st.

What about this

block_assembler.message_options: {
  embed_client_version: bool, // default is true
}

I like this.

[quake]

@keroro520 @zhangsoledad changed the configuration field name to use_binary_version_as_message_prefix, please review again, thanks.

[quake]

bors r=keroro520,zhangsoledad,driftluo,yangby-cryptape

[bors]

Build succeeded:

• ci