Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove needless collect #3139

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Oct 23, 2021

What is changed and how it works?

remove needless collect

Release note

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner October 23, 2021 03:59
Copy link
Collaborator

@yangby-cryptape yangby-cryptape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: this boolean expression can be simplified
   --> verification/contextual/src/contextual_block_verifier.rs:185:12
    |
185 |         if !committed_ids.difference(&proposal_txs_ids).next().is_none() {
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `committed_ids.difference(&proposal_txs_ids).next().is_some()`
    |
    = note: `-D clippy::nonminimal-bool` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool

error: aborting due to previous error

error: could not compile `ckb-verification-contextual`

@zhangsoledad
Copy link
Member Author

#benchmark

@zhangsoledad
Copy link
Member Author

bors r=yangby-cryptape,keroro520

@bors bors bot merged commit c3b877e into nervosnetwork:develop Oct 23, 2021
@zhangsoledad zhangsoledad deleted the zhangsoledad/avoid-collect branch October 23, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants