Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade tentacle #3459

Merged
merged 1 commit into from
Jun 30, 2022
Merged

feat: upgrade tentacle #3459

merged 1 commit into from
Jun 30, 2022

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Jun 21, 2022 •
edited
Loading

What problem does this PR solve?

introduce async_trait to ckb

this is a break change for ckb, it upgrade tentacle from 0.4.0-aphla to 0.4.0

ckb-network will also use async_trait to ckb protocol

release note

Check List

Tests

  • Unit test
  • Integration test

Release note

None: Exclude this PR from the release note.

@driftluo driftluo force-pushed the upgrade-tentacle branch 8 times, most recently from 628540a to 847f1a9 Compare June 23, 2022 06:41
@driftluo driftluo marked this pull request as ready for review June 23, 2022 07:42
@driftluo driftluo requested a review from a team as a code owner June 23, 2022 07:42
@driftluo driftluo requested review from zhangsoledad and removed request for a team June 23, 2022 07:42
quake
quake requested changes Jun 29, 2022
View reviewed changes
network/src/protocols/mod.rs Show resolved Hide resolved
@driftluo driftluo requested a review from quake June 30, 2022 09:36
@driftluo driftluo changed the title chore: upgrade tentacle feat: upgrade tentacle Jun 30, 2022
@driftluo
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 30, 2022

Build succeeded:

@bors bors bot merged commit 5819c75 into nervosnetwork:develop Jun 30, 2022
@driftluo driftluo deleted the upgrade-tentacle branch June 30, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftluo @quake @zhangsoledad