Fix tx-pool potential inconsistent after reorg occurs #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
zhangsoledad/tx-pool-fix
branch
4 times, most recently
from
1aa6484 to
d724ca4
Compare
zhangsoledad
force-pushed
the
zhangsoledad/tx-pool-fix
branch
from
d724ca4 to
6b6b72a
Compare
quake
approved these changes
Nov 17, 2022
driftluo
approved these changes
Nov 17, 2022
|
bors r+ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Usually when a new transaction is added to the pool, it has no in-pool children (because any such children would be an orphan). In the event of a reorg, the assumption that a newly added tx has no in-pool children is false. In particular, the pool is in an inconsistent state while new transactions are being added.
What is changed and how it works?
When a reorg occurs and the tx-pool adds transactions from the disconnect block, it also updates the state of the corresponding descendants to ensure that the state is consistent.
Check List
Tests
Release note