Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix CKB command line usage test case by bats-core/bats #3893

Merged
merged 5 commits into from
Mar 24, 2023
Merged

CI: Fix CKB command line usage test case by bats-core/bats #3893

merged 5 commits into from
Mar 24, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Mar 21, 2023 •
edited
Loading

What problem does this PR solve?

This PR want to enhance test case for ckb command line usage. Related: #3892
Cc. @quake

  • upgrade bats-core/bats, bats-core/bats-assert and bats-core/bats-support
  • fix *.bats tests in util/app-config/src/tests
  • Add a way to run *.bats test in Makefile ( make cli-test)

What is changed and how it works?

Related changes

  • Upgrade bats toolkit version in CI job.
  • Fix ckb list-hashes and ckb list-hashes -b bats test case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec force-pushed the debug/ci_cli_test branch 3 times, most recently from cc32378 to a494f45 Compare March 21, 2023 06:17
@eval-exec eval-exec changed the title CI: debug why cli_test.sh not work as expected CI: fix bats tests not work as expected Mar 21, 2023
@eval-exec eval-exec changed the title CI: fix bats tests not work as expected CI: Enhance CKB command line usage test case by bats-core/bats Mar 21, 2023
@eval-exec eval-exec changed the title CI: Enhance CKB command line usage test case by bats-core/bats CI: Fix CKB command line usage test case by bats-core/bats Mar 21, 2023
@eval-exec eval-exec marked this pull request as ready for review March 21, 2023 08:55
@eval-exec eval-exec requested a review from a team as a code owner March 21, 2023 08:55
@eval-exec eval-exec requested review from zhangsoledad and quake and removed request for a team March 21, 2023 08:55
@eval-exec
ci: upgrade bats-core/bats and related tools version
8031cfc 
Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec
fix CKB cli usage test cases in cli.bats
6eb8dd0 
Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec self-assigned this Mar 21, 2023
@eval-exec eval-exec added the t:ci Type: CI label Mar 21, 2023
@eval-exec eval-exec requested a review from doitian March 23, 2023 03:31
@eval-exec eval-exec marked this pull request as draft March 23, 2023 03:32
@eval-exec eval-exec marked this pull request as ready for review March 23, 2023 11:01
@eval-exec
Copy link
Collaborator Author

I think this PR is ready for review.

@eval-exec eval-exec marked this pull request as draft March 23, 2023 13:06
@eval-exec eval-exec marked this pull request as ready for review March 23, 2023 13:37
@eval-exec
Copy link
Collaborator Author

There is a CI action which cost 8 hours: https://github.com/nervosnetwork/ckb/actions/runs/4499249342/jobs/7916891732

@zhangsoledad zhangsoledad added this pull request to the merge queue Mar 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2023
@zhangsoledad
Copy link
Member

blocking by #3904

@zhangsoledad zhangsoledad added this pull request to the merge queue Mar 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Mar 24, 2023
@eval-exec
Copy link
Collaborator Author

https://github.com/nervosnetwork/ckb/actions/runs/4509147319/jobs/7938569945

Weirdly, CI action failed to copy target/release/ckb to /tmp/ckb_bats_testbed:

cp: cannot stat 'target/release/ckb': No such file or directory

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2023
@eval-exec eval-exec marked this pull request as draft March 24, 2023 09:01
@eval-exec eval-exec marked this pull request as ready for review March 24, 2023 09:11
@eval-exec eval-exec force-pushed the debug/ci_cli_test branch 2 times, most recently from 21df909 to 70e2ec9 Compare March 24, 2023 09:14
@zhangsoledad zhangsoledad added this pull request to the merge queue Mar 24, 2023
Merged via the queue into nervosnetwork:develop with commit 31d836b Mar 24, 2023
@eval-exec eval-exec deleted the debug/ci_cli_test branch March 24, 2023 10:17
@eval-exec
Copy link
Collaborator Author

CI integration test failed on MacOS (https://github.com/nervosnetwork/ckb/actions/runs/4510071188/jobs/7940588698)

ERROR ckb_test ckb-test failed on spec BlockSyncDuplicatedAndReconnect

@doitian doitian mentioned this pull request Apr 13, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

@doitian doitian Awaiting requested review from doitian

Assignees

@eval-exec eval-exec

Labels
t:ci Type: CI
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @zhangsoledad @quake