Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ckb init creates config files even when an unsupported spec is specified. #4012

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Fix: ckb init creates config files even when an unsupported spec is specified. #4012

merged 1 commit into from
Jun 15, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Jun 14, 2023 •
edited
Loading

What problem does this PR solve?

Problem Summary:

In the current ckb implementation: ckb init --chain unsupported_spec will create config files:
image

image

What is changed and how it works?

I think config files should NOT be created if ckb init --chain got an unsupported spec name.

So I make some change:

What's Changed:

Related changes

  • Add possible values to ckb init --chain's

image

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner June 14, 2023 08:45
@eval-exec eval-exec requested review from doitian and removed request for a team June 14, 2023 08:45
@eval-exec eval-exec changed the title Fix: ckb init --chain unsupported_spec should not create config files Fix: ckb init creates config files even when an unsupported spec is specified. Jun 14, 2023
@eval-exec eval-exec added the b:cli Break cli options and config file label Jun 14, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Jun 15, 2023
@zhangsoledad zhangsoledad merged commit 8ca2f19 into nervosnetwork:develop Jun 15, 2023
@zhangsoledad zhangsoledad mentioned this pull request Jun 16, 2023
Merged
@doitian doitian mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftluo driftluo driftluo approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
b:cli Break cli options and config file
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @zhangsoledad @driftluo