Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure random_2_in_2_out_rtx() suspends on first execution #4027

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Jun 20, 2023

What problem does this PR solve?

This CI action failed, because the 2_in_2_out_rtx may completed after first run.
And we didn't handle the else case:

if let VerifyResult::Suspended(state) = verifier.resumable_verify(step_cycles).unwrap() {
init_snap = Some(state.try_into().unwrap());
}

Then init_state will be None, and panic will happen.

Since the random_2_in_2_out_rtx will consume 3276322 cycles, increase CYCLE_BOUND from 200_000 to 250_000 will make sure suspend/resume will happen in verification.

What's Changed:

Related changes

  • Increase CYCLE_BOUND to 250_000

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner June 20, 2023 10:34
@eval-exec eval-exec requested review from doitian and zhangsoledad and removed request for a team June 20, 2023 10:34
@eval-exec eval-exec changed the title Make sure random_2_in_2_out_rtx() will suspend on first run Ensure random_2_in_2_out_rtx() will suspend on first execution Jun 20, 2023
@eval-exec eval-exec changed the title Ensure random_2_in_2_out_rtx() will suspend on first execution Ensure random_2_in_2_out_rtx() suspends on first execution Jun 20, 2023
@eval-exec eval-exec added the t:ci Type: CI label Jun 20, 2023
@quake quake added this pull request to the merge queue Jun 20, 2023
Merged via the queue into nervosnetwork:develop with commit a645ef2 Jun 20, 2023
@eval-exec eval-exec deleted the exec/fix-unit-test-for-resume-may-complete-at-first branch June 20, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:ci Type: CI
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants