Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Txpool will evict tx when resolve error in block assembler #4220

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Txpool will evict tx when resolve error in block assembler #4220

merged 1 commit into from
Nov 6, 2023

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Tx may stay for a long time in txpool, when resolve error happened in block assembler.

Problem Summary:

What is changed and how it works?

txpool remove checking failed txs.

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner November 3, 2023 06:03
@chenyukang chenyukang requested review from doitian and removed request for a team November 3, 2023 06:03
@zhangsoledad zhangsoledad added this pull request to the merge queue Nov 6, 2023
Merged via the queue into nervosnetwork:develop with commit e18ee1e Nov 6, 2023
34 checks passed
@eval-exec eval-exec mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyukang @zhangsoledad @eval-exec