Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix windows ci error failed for daemon option #4287

Merged

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

The CI is failing because of an cfg error in #4237 , we may need to investigate why CI failure may still get the PR was merged successfully.

https://github.com/nervosnetwork/ckb/actions/runs/7354769222/job/20022410084

Problem Summary:

What is changed and how it works?

Windows don't have daemon option.

What's Changed:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner December 29, 2023 17:01
@chenyukang chenyukang requested review from doitian and removed request for a team December 29, 2023 17:01
@doitian doitian added this pull request to the merge queue Dec 29, 2023
Merged via the queue into nervosnetwork:develop with commit 07f01e9 Dec 30, 2023
32 checks passed
@chenyukang chenyukang changed the title chore: ix windows ci error failed for daemon option chore: fix windows ci error failed for daemon option Dec 30, 2023
OctoSabercat

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants