-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evict possible cell ref txs before submitting cell consuming transaction #4363
Merged
chenyukang
merged 11 commits into
nervosnetwork:develop
from
chenyukang:yukang-fix-cell-dep
Mar 7, 2024
Merged
Evict possible cell ref txs before submitting cell consuming transaction #4363
chenyukang
merged 11 commits into
nervosnetwork:develop
from
chenyukang:yukang-fix-cell-dep
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
changed the title
Evict possible cell ref txs before submit cell consuming transaction
Evict possible cell ref txs before submitting cell consuming transaction
Feb 23, 2024
chenyukang
force-pushed
the
yukang-fix-cell-dep
branch
8 times, most recently
from
February 26, 2024 00:54
e79121f
to
cd0c0aa
Compare
doitian
reviewed
Feb 29, 2024
chenyukang
force-pushed
the
yukang-fix-cell-dep
branch
from
February 29, 2024 03:15
638b3ff
to
c8948be
Compare
doitian
previously approved these changes
Feb 29, 2024
chenyukang
force-pushed
the
yukang-fix-cell-dep
branch
from
February 29, 2024 03:51
9c29d80
to
8a360c0
Compare
doitian
previously approved these changes
Mar 5, 2024
1 task
chenyukang
force-pushed
the
yukang-fix-cell-dep
branch
from
March 7, 2024 06:34
8a360c0
to
763ea0d
Compare
doitian
approved these changes
Mar 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
The are conflicts rule between cell dep reference and cell consume relationships.
Assume there are 3 transactions, B cell dep A(and there may be many transactions also cell dep A), C consumes A.
txpool
.What is changed and how it works?
This is an alternative solution with #4352
In this PR, we introduce these changes:
check_entry_ancestors_limit
to find all candidates needed to evict due to cell ref conflicts, based onevict_score
.DirectParents
anddirect_ancestors_count
, we make sure an entry's ancestors number is valid after evicting conflicted cell ref transactions.ExceededMaximumAncestorsCount
check to place before inserting, so that we can assume there will no error report when committing a entry.What's Changed:
Related changes
owner/repo
:Check List
Tests
Side effects
Release note