Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket subscription performance issue #4505

Merged

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Fixes #4489

The current channel size is too small, which may introduce RecvError::Lagged when the workload is high.

What is changed and how it works?

What's Changed:

  • enlarge the notify channel size, keep it same with ckb_notify::NOTIFY_CHANNEL_SIZE.
  • ignore the RecvError::Lagged and continue to get the later notifications.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner June 27, 2024 09:53
@chenyukang chenyukang requested review from zhangsoledad and removed request for a team June 27, 2024 09:53
@chenyukang chenyukang force-pushed the yukang-websocket-perf branch from 0ea9561 to 55f6d96 Compare June 27, 2024 09:53
@zhangsoledad zhangsoledad added this pull request to the merge queue Jun 27, 2024
Merged via the queue into nervosnetwork:develop with commit 648c8c7 Jun 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issue about websocket of CKB node
3 participants