VerifyQueue
: re_notify other Worker when OnlySmallCycleTx
received a large cycle tx
#4591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
we found
SendLargeCyclesTxToRelay
is not stable, seems some large cycle tx is not properly processed when replay.The root cause is when
verify_queue
wake up aOnlySmallCycleTx
to large cycle tx, the worker will directly return, then other worker also miss the chance to pick it up.Related changes
Worker::process_inner
re_notify other workers if current worker is aOnlySmallCycleTx
Worker, but there is large cycle tx inVerifyQueue
Check List
Tests
Side effects
Release note