-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VerifyQueue
: re_notify other Worker when OnlySmallCycleTx
received a large cycle tx
#4591
Merged
eval-exec
merged 2 commits into
nervosnetwork:develop
from
eval-exec:exec/fix-verify-mgr
Aug 15, 2024
Merged
VerifyQueue
: re_notify other Worker when OnlySmallCycleTx
received a large cycle tx
#4591
eval-exec
merged 2 commits into
nervosnetwork:develop
from
eval-exec:exec/fix-verify-mgr
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge cycle tx Signed-off-by: Eval EXEC <execvy@gmail.com>
28f21d5
to
9ffbc3a
Compare
chenyukang
reviewed
Aug 15, 2024
VerifyQueue
: re_notify other Worker when OnlySmallCycleTx
received a large cycle tx
…ck tasks is not empty Signed-off-by: Eval EXEC <execvy@gmail.com>
eeb03f1
to
366c3f5
Compare
driftluo
approved these changes
Aug 15, 2024
chenyukang
reviewed
Aug 15, 2024
chenyukang
approved these changes
Aug 15, 2024
|
Retry merge... |
emm, what this error... |
I think this error may related to Rocksdb's `OptimisticTransaction`
…On 8/15/24 7:56 PM, Yukang ***@***.***> wrote:
emm, what this error...
—
Reply to this email directly, view it on GitHub
<#4591 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCAINXMQAJWJYJCBMQEXPDZRSJPDAVCNFSM6AAAAABMR56EGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGEZTQMZYGM>.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
we found
SendLargeCyclesTxToRelay
is not stable, seems some large cycle tx is not properly processed when replay.The root cause is when
verify_queue
wake up aOnlySmallCycleTx
to large cycle tx, the worker will directly return, then other worker also miss the chance to pick it up.Related changes
Worker::process_inner
re_notify other workers if current worker is aOnlySmallCycleTx
Worker, but there is large cycle tx inVerifyQueue
Check List
Tests
Side effects
Release note