Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(script): remove isa a in version 2 #4664

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(script): remove isa a in version 2 #4664

merged 1 commit into from
Sep 25, 2024

Conversation

mohanson
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

ISA_A should not be contained in version 2.

What is changed and how it works?

What's Changed:

Remove ISA_A flag.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Breaking backward compatibility

Release note 

Note: Add a note under the PR title in the release note.

@mohanson mohanson requested a review from a team as a code owner September 25, 2024 07:41
@mohanson mohanson requested review from quake and removed request for a team September 25, 2024 07:41
@zhangsoledad zhangsoledad added this pull request to the merge queue Sep 25, 2024
Merged via the queue into nervosnetwork:develop with commit d8fc09a Sep 25, 2024
31 of 32 checks passed
@mohanson mohanson deleted the disable_isa_a branch September 25, 2024 09:22
@doitian doitian mentioned this pull request Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohanson @zhangsoledad