Add unit test to check the validitiy of commitment transaction #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contrun
force-pushed
the
test-commitment-tx-validity
branch
from
4336f08 to
9037cc4
Compare
contrun
force-pushed
the
test-commitment-tx-validity
branch
from
734e170 to
5d1bb6e
Compare
chenyukang
reviewed
Jun 5, 2024
| return Ok(()); | ||
| } | ||
| let current_capacity: u64 = output.capacity().unpack(); | ||
| let capacity = request.local_amount + current_capacity; |
There was a problem hiding this comment.
emm, we need to care about UDT on this part.
There was a problem hiding this comment.
Yeah. We should also take care of UDT here, which would depend on your work. So, for now, we'd better leave this as a known issue.
chenyukang
approved these changes
Jun 5, 2024
quake
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partly resolves #26. It tests that we can broadcast the commitment transaction to the network (i.e. commitment transaction is valid). We need also to create a test which consumes the comitment tx output (e.g.with revocation key).
The notable changes to this PR are:
SendTxwill be verified. If this transaction is invalid then the response toTraceTxrequest will returnStatus::Rejected. This is very useful to quickly check the validity of any transactions. In this PR, I used this infrastructure to test the commitment transaction can indeed consume the funding cell.CommitmentSignaturePendingwhich tells the owner it is his turn to sign a commitment transaction (this makes it quite easy to solve Automatically generate CommitmentSigned responses in channel establishment #27,.RemoteCommitmentSignedto signify a new commitment is signed by the remote.