Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disable channel and private channel send payment issue #502

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Jan 26, 2025

1: Fixes #499, disable will respect direction, for scenario a -> b -> c, if b disable b -> c, c can send payment with c -> b -> a.

2: Fix a payment issue in channel forwarding.

@gpBlockchain
Copy link
Contributor

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.58%. Comparing base (f624685) to head (e7bb887).

Files with missing lines Patch % Lines
src/fiber/channel.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #502      +/-   ##
===========================================
+ Coverage    50.56%   50.58%   +0.01%     
===========================================
  Files           49       49              
  Lines        31945    31944       -1     
===========================================
+ Hits         16154    16159       +5     
+ Misses       15791    15785       -6     
Flag Coverage Δ
unittests 50.58% <60.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenyukang chenyukang force-pushed the fix-499-disable branch 2 times, most recently from 128081b to 558e2c0 Compare January 27, 2025 01:50
@chenyukang chenyukang changed the title Fix disable channel and private channel issue Fix disable channel and private channel send payment issue Jan 27, 2025
@chenyukang chenyukang force-pushed the fix-499-disable branch 2 times, most recently from f5fdbc0 to d9868aa Compare January 27, 2025 04:52
@quake quake merged commit 09f4dfe into develop Feb 5, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[update_channel] send_payment failed when enabled is false
4 participants