Fix get sent/received tlc value #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contrun
force-pushed
the
fix-balance-calculation
branch
from
f924c83
to
523e759
Compare
contrun
force-pushed
the
fix-balance-calculation
branch
from
523e759
to
14fefe8
Compare
doitian
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something is wrong with current calculation of the amount of sent/received money. The error is discovered by @chenyukang while developing #69 . This PR is currently untested. There are still a lot of things I need to improve (first, the TODO listed in the code, second, make a test case to ensure the balance is calculated correctly). This is meant to be a hotfix.