-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC29: Allow multiple matches on dep cells via type script hash when these cells have the same data #222
Merged
doitian
merged 3 commits into
nervosnetwork:master
from
doitian:allow-script-multiple-matches-on-identical-code
Mar 31, 2022
Merged
RFC29: Allow multiple matches on dep cells via type script hash when these cells have the same data #222
doitian
merged 3 commits into
nervosnetwork:master
from
doitian:allow-script-multiple-matches-on-identical-code
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Jun 15, 2021
2715: feat(hardfork): ckb2021 hardfork features r=yangby-cryptape a=yangby-cryptape ### Suggestions for Review **The best way to review this PR is reviewing each commit independently.** ### Brief introduction for Commits #### New hardfork Features **All following features can be found in RFC PRs.** - feat(hardfork): in the "since epoch", the index should be less than length Ref: [CKB-RFCs PR 223: Ensure that index < length in input since field using epoch](nervosnetwork/rfcs#223) - feat(hardfork): use block timestamp of input cells as relative since start timestamp Ref: [CKB-RFCs PR 221: Use Block Timestamp as Start Timestamp in Since](nervosnetwork/rfcs#221) - **[Reverted]** ~~feat(hardfork): allow unknown block versions and transactions versions~~ ~~Ref: [CKB-RFCs PR 230: Allow unknown tx & block version](nervosnetwork/rfcs#230 - feat(hardfork): allow script multiple matches on identical data for type hash-type scripts Ref: [CKB-RFCs PR 222: Allow script multiple matches on identical code](nervosnetwork/rfcs#222) - feat(hardfork): reuse the uncles hash in the header as the extra hash Ref: [CKB-RFCs PR 224: Add a variable length field in the block header](nervosnetwork/rfcs#224) - **[Reverted]** ~~feat(hardfork): allow loading uncommitted cell data hashes from tx pool~~ ~~Ref: [CKB-RFCs PR 228: ckb2021: fix load_cell_data_hash syscall](nervosnetwork/rfcs#228 #### Other Important Commits - feat(hardfork): setup the components for hard fork features - refactor: let verifiers know the real environment that the transaction is in Almost all features require this refactor commit. - refactor: remove useless parameter "with_data" because it always be true (tricky) So I can change less APIs and less code to apply the feature: allow loading uncommitted cell data hashes from tx pool. ### About Tests Almost all features have detailed integration tests (or unit tests): - Many blocks before hardfork; - Only one block before hardfork; - The block at hardfork; - Many blocks after hardfork. All commits can passed all integration tests and unit tests. Co-authored-by: zhangsoledad <787953403@qq.com> Co-authored-by: Boyu Yang <yangby@cryptape.com>
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Jun 15, 2021
2715: feat(hardfork): ckb2021 hardfork features r=quake,doitian,zhangsoledad a=yangby-cryptape ### Suggestions for Review **The best way to review this PR is reviewing each commit independently.** ### Brief introduction for Commits #### New hardfork Features **All following features can be found in RFC PRs.** - feat(hardfork): in the "since epoch", the index should be less than length Ref: [CKB-RFCs PR 223: Ensure that index < length in input since field using epoch](nervosnetwork/rfcs#223) - feat(hardfork): use block timestamp of input cells as relative since start timestamp Ref: [CKB-RFCs PR 221: Use Block Timestamp as Start Timestamp in Since](nervosnetwork/rfcs#221) - **[Reverted]** ~~feat(hardfork): allow unknown block versions and transactions versions~~ ~~Ref: [CKB-RFCs PR 230: Allow unknown tx & block version](nervosnetwork/rfcs#230 - feat(hardfork): allow script multiple matches on identical data for type hash-type scripts Ref: [CKB-RFCs PR 222: Allow script multiple matches on identical code](nervosnetwork/rfcs#222) - feat(hardfork): reuse the uncles hash in the header as the extra hash Ref: [CKB-RFCs PR 224: Add a variable length field in the block header](nervosnetwork/rfcs#224) - **[Reverted]** ~~feat(hardfork): allow loading uncommitted cell data hashes from tx pool~~ ~~Ref: [CKB-RFCs PR 228: ckb2021: fix load_cell_data_hash syscall](nervosnetwork/rfcs#228 #### Other Important Commits - feat(hardfork): setup the components for hard fork features - refactor: let verifiers know the real environment that the transaction is in Almost all features require this refactor commit. - refactor: remove useless parameter "with_data" because it always be true (tricky) So I can change less APIs and less code to apply the feature: allow loading uncommitted cell data hashes from tx pool. ### About Tests Almost all features have detailed integration tests (or unit tests): - Many blocks before hardfork; - Only one block before hardfork; - The block at hardfork; - Many blocks after hardfork. All commits can passed all integration tests and unit tests. Co-authored-by: zhangsoledad <787953403@qq.com> Co-authored-by: Boyu Yang <yangby@cryptape.com>
keroro520
reviewed
Jun 28, 2021
...t-multiple-matches-on-identical-code/0000-allow-script-multiple-matches-on-identical-code.md
Outdated
Show resolved
Hide resolved
doitian
commented
Jun 30, 2021
...t-multiple-matches-on-identical-code/0000-allow-script-multiple-matches-on-identical-code.md
Outdated
Show resolved
Hide resolved
...t-multiple-matches-on-identical-code/0000-allow-script-multiple-matches-on-identical-code.md
Outdated
Show resolved
Hide resolved
yangby-cryptape
previously approved these changes
Jul 13, 2021
doitian
changed the title
RFC: Allow script multiple matches on identical code
RFC222: Allow script multiple matches on identical code
Jul 22, 2021
doitian
force-pushed
the
allow-script-multiple-matches-on-identical-code
branch
from
July 22, 2021 14:48
fd93c16
to
e8a5661
Compare
janx
requested changes
Jul 23, 2021
...t-multiple-matches-on-identical-code/0222-allow-script-multiple-matches-on-identical-code.md
Outdated
Show resolved
Hide resolved
This was referenced Jul 23, 2021
doitian
changed the title
RFC222: Allow script multiple matches on identical code
RFC29: Allow script multiple matches on identical code
Jul 23, 2021
doitian
force-pushed
the
allow-script-multiple-matches-on-identical-code
branch
from
July 23, 2021 07:24
e8a5661
to
c239579
Compare
doitian
force-pushed
the
allow-script-multiple-matches-on-identical-code
branch
from
July 23, 2021 07:33
db2f640
to
808be91
Compare
doitian
changed the title
RFC29: Allow script multiple matches on identical code
RFC29: Allow multiple matches on dep cells via type script hash when these cells have the same data
Jul 24, 2021
EthanYuan
reviewed
Aug 11, 2021
...t-multiple-matches-on-identical-code/0029-allow-script-multiple-matches-on-identical-code.md
Outdated
Show resolved
Hide resolved
…-allow-script-multiple-matches-on-identical-code.md Co-authored-by: Chengxing Yuan <yuanchengxing@hotmail.com>
yangby-cryptape
previously approved these changes
Jan 4, 2022
xxuejie
reviewed
Mar 3, 2022
...t-multiple-matches-on-identical-code/0029-allow-script-multiple-matches-on-identical-code.md
Show resolved
Hide resolved
...t-multiple-matches-on-identical-code/0029-allow-script-multiple-matches-on-identical-code.md
Outdated
Show resolved
Hide resolved
...t-multiple-matches-on-identical-code/0029-allow-script-multiple-matches-on-identical-code.md
Outdated
Show resolved
Hide resolved
...t-multiple-matches-on-identical-code/0029-allow-script-multiple-matches-on-identical-code.md
Outdated
Show resolved
Hide resolved
...t-multiple-matches-on-identical-code/0029-allow-script-multiple-matches-on-identical-code.md
Show resolved
Hide resolved
...t-multiple-matches-on-identical-code/0029-allow-script-multiple-matches-on-identical-code.md
Outdated
Show resolved
Hide resolved
xxuejie
approved these changes
Mar 4, 2022
quake
approved these changes
Mar 5, 2022
janx
approved these changes
Mar 14, 2022
doitian
added
the
s:fcp
Final Comment Period. PR is merged when there's no comments in 14 days.
label
Mar 14, 2022
FCP will end on 2022-03-28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
b:consensus
Break consensus
ckb2021
Hard fork scheduled in 2021
hard-fork
s:fcp
Final Comment Period. PR is merged when there's no comments in 14 days.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.