Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC24: add cheque info #241

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

rev-chaos
Copy link
Contributor

@rev-chaos rev-chaos commented Jul 8, 2021

You can send and claim a cheque cell in the Lina by mercury with mainnet configuration with the rightful cheque settings written in this RFC.

A theoretical way to verify:

  1. The code_hash of cheque script is 0x00000000000000000000000000000000000000000000000000545950455f4944. See the cheque deploy transaction for mainnet and testnet. The deploy info is also written in this PR.
    So, the binary code of cheque is consistent between mainnet and testnet.
  2. The data of dep_group cell is completely obeying the dep group rules.
  3. We have fully tested the cheque deploying ones on the testnet by mercury. An example for create cheque cell. An example for claim cheque cell.
    So, according to theoretical derivation, we can make sure the cheque dep_group cell in mainnet can work.

A practical way to verify: Use ckb-sdk v0.43.1 or above to successfully create a cheque cell.

  1. Get some CKB and sUDT for test. CKB for test should above 305.
  2. Set mainnet mercury URL in ckb-sdk, java or go . We have deployed a public server here (https://mercury-mainnet.ckbapp.dev/ ) for mainnet mercury, so you can save much time for syning data.
  3. Run a test to create a cheque cell. Test code in java or go .

@rev-chaos rev-chaos requested a review from a team as a code owner July 8, 2021 13:32
@rev-chaos rev-chaos requested review from doitian and xxuejie July 8, 2021 13:32
@doitian doitian changed the title RFC: add cheque info RFC24: add cheque info Jul 23, 2021
Copy link
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide instructions of how to verify the information is correct.

  • How to check code_hash, hash_type and dep group content.

@rev-chaos
Copy link
Contributor Author

rev-chaos commented Aug 9, 2021

Please provide instructions of how to verify the information is correct.

  • How to check code_hash, hash_type and dep group content.

You can send and claim a cheque cell in the Lina by mercury with mainnet configuration with the rightful cheque settings written in this RFC.

A theoretical way to verify:

  1. The code_hash of cheque script is 0x00000000000000000000000000000000000000000000000000545950455f4944. See the cheque deploy transaction for mainnet and testnet. The deploy info is also written in this PR.
    So, the binary code of cheque is consistent between mainnet and testnet.
  2. The data of dep_group cell is completely obeying the dep group rules.
  3. We have fully tested the cheque deploying ones on the testnet by mercury. An example for create cheque cell. An example for claim cheque cell.
    So, according to theoretical derivation, we can make sure the cheque dep_group cell in mainnet can work.

A practical way to verify: Use ckb-sdk v0.43.1 or above to successfully create a cheque cell.

  1. Get some CKB and sUDT for test. CKB for test should above 305.
  2. Set mainnet mercury URL in ckb-sdk, java or go . We have deployed a public server here (https://mercury-mainnet.ckbapp.dev/ ) for mainnet mercury, so you can save much time for syning data.
  3. Run a test to create a cheque cell. Test code in java or go .

@doitian doitian merged commit fe0230f into nervosnetwork:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants