[WIP] 1.0.0 release #64

nesaulov · 2018-01-26T21:42:44Z

What is done

Keyword arguments were replaced with normal arguments
Added dynamically built and included module that holds methods from json_schema for classes that inherit from Surrealist::Serializer

TODO

Add benchmarks for associations
See how else performance could be improved
Update README with ORMs section
Update ROADMAP

nesaulov · 2018-01-26T21:44:54Z

Right now we have this (ruby 2.4.2):

Warming up --------------------------------------
       AMS: instance   808.000  i/100ms
Surrealist: instance through .surrealize
                         1.960k i/100ms
Surrealist: instance through Surrealist::Serializer
                         1.630k i/100ms
Calculating -------------------------------------
       AMS: instance      6.816k (±16.3%) i/s -     33.128k in   5.010265s
Surrealist: instance through .surrealize
                         19.085k (± 9.7%) i/s -     96.040k in   5.088542s
Surrealist: instance through Surrealist::Serializer
                         17.679k (± 7.3%) i/s -     88.020k in   5.005971s

Comparison:
Surrealist: instance through .surrealize:    19085.2 i/s
Surrealist: instance through Surrealist::Serializer:    17679.4 i/s - same-ish: difference falls within error
       AMS: instance:     6815.9 i/s - 2.80x  slower

---

Warming up --------------------------------------
     AMS: collection     1.000  i/100ms
Surrealist: collection through Surrealist.surrealize_collection()
                         1.000  i/100ms
Surrealist: collection through Surrealist::Serializer
                         1.000  i/100ms
Calculating -------------------------------------
     AMS: collection      4.344  (±23.0%) i/s -     22.000  in   5.152137s
Surrealist: collection through Surrealist.surrealize_collection()
                          3.913  (± 0.0%) i/s -     20.000  in   5.128616s
Surrealist: collection through Surrealist::Serializer
                          3.347  (± 0.0%) i/s -     17.000  in   5.092593s

Comparison:
     AMS: collection:        4.3 i/s
Surrealist: collection through Surrealist.surrealize_collection():        3.9 i/s - same-ish: difference falls within error
Surrealist: collection through Surrealist::Serializer:        3.3 i/s - same-ish: difference falls within error

houndci-bot · 2018-01-27T14:12:21Z

benchmarks/surrealist_vs_ams.rb

+  x.compare!
+end
+
+


Extra blank line detected.

houndci-bot · 2018-01-27T14:12:21Z

benchmarks/surrealist_vs_ams.rb

+  x.compare!
+end
+
+


Extra blank line detected.

…n_schema for classes that inherit from Surrealist::Serializer

nesaulov · 2018-01-30T20:47:24Z

Progress:

# ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-darwin16]
# -- Instance --
# Comparison:
#   Surrealist: instance through .surrealize:    22068.7 i/s
#   Surrealist: instance through Surrealist::Serializer:    18691.4 i/s - same-ish: difference falls within error
#   AMS: instance:     2847.9 i/s - 7.75x  slower
#
# -- Collection --
# Comparison:
#   Surrealist: collection through Surrealist.surrealize_collection():        8.3 i/s
#   Surrealist: collection through Surrealist::Serializer:        7.5 i/s - same-ish: difference falls within error
#   AMS: collection:        5.9 i/s - 1.41x  slower
#
# --- Without AMS logging (which is turned on by default) ---
#
# -- Instance --
# Comparison:
#   Surrealist: instance through .surrealize:    21317.8 i/s
#   Surrealist: instance through Surrealist::Serializer:    18273.7 i/s - same-ish: difference falls within error
#   AMS(without logging): instance:     4108.7 i/s - 4.96x  slower
#
# -- Collection --
# Comparison:
#   Surrealist: collection through Surrealist.surrealize_collection():        8.5 i/s
#   Surrealist: collection through Surrealist::Serializer:        7.4 i/s - same-ish: difference falls within error
#   AMS(without logging): collection:        6.2 i/s - 1.37x  slower
#
# --- Associations ---
#
# -- Instance --
# Comparison:
#   Surrealist (associations): instance through .surrealize:     3093.0 i/s
#   Surrealist (associations): instance through Surrealist::Serializer:     3064.6 i/s - same-ish: difference falls within error
#   AMS (associations): instance:     1580.8 i/s - 2.04x  slower
#
# -- Collection --
# Comparison:
#   Surrealist (associations): collection through Surrealist.surrealize_collection():        2.0 i/s
#   Surrealist (associations): collection through Surrealist::Serializer:        2.0 i/s - 1.02x  slower
#   AMS (associations): collection:        1.3 i/s - 1.46x  slower

nesaulov · 2018-02-03T14:43:31Z

@AlessandroMinali do you have ideas or suggestions what can be improved performance-wise or in general before the release?

nesaulov · 2018-02-03T14:54:16Z

Actually, I have done some profiling right now, and it seems that the most expensive operation in the whole gem was String#match :)

Measure Mode: wall_time
Thread ID: 70115777572540
Fiber ID: 70115787074260
Total: 21.248953
Sort by: self_time

 %self      total      self      wait     child     calls  name
  6.08      1.713     1.291     0.000     0.423   403940   String#match
  3.90      8.274     0.829     0.000     7.446   364374  *Hash#each
  3.10      3.088     0.658     0.000     2.430   403940   <Module::Surrealist::TypeHelper>#dry_type?

This is stupid, so I am going to fix that part of TypeHelper

nesaulov · 2018-02-03T15:59:32Z

More progress:

# ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-darwin16]
# -- Instance --
# Comparison:
#   Surrealist: instance through .surrealize:    28945.6 i/s
#   Surrealist: instance through Surrealist::Serializer:    22889.2 i/s - same-ish: difference falls within error
#   AMS: instance:     1684.5 i/s - 17.18x  slower
#
# -- Collection --
# Comparison:
#   Surrealist: collection through Surrealist.surrealize_collection():       15.0 i/s
#   Surrealist: collection through Surrealist::Serializer:       12.8 i/s - 1.17x  slower
#   AMS: collection:        6.1 i/s - 2.44x  slower
#
# --- Without AMS logging (which is turned on by default) ---
#
# -- Instance --
# Comparison:
#   Surrealist: instance through .surrealize:    36503.6 i/s
#   Surrealist: instance through Surrealist::Serializer:    27772.8 i/s - 1.31x  slower
#   AMS(without logging): instance:     4751.2 i/s - 7.68x  slower
#
# -- Collection --
# Comparison:
#   Surrealist: collection through Surrealist.surrealize_collection():       15.2 i/s
#   Surrealist: collection through Surrealist::Serializer:       12.0 i/s - 1.27x  slower
#   AMS(without logging): collection:        6.1 i/s - 2.50x  slower
#
# --- Associations ---
#
# -- Instance --
# Comparison:
#   Surrealist (associations): instance through Surrealist::Serializer:     4122.8 i/s
#   Surrealist (associations): instance through .surrealize:     4056.9 i/s - same-ish: difference falls within error
#   AMS (associations): instance:     1721.8 i/s - 2.39x  slower
#
# -- Collection --
# Comparison:
#   Surrealist (associations): collection through Surrealist.surrealize_collection():        2.0 i/s
#   Surrealist (associations): collection through Surrealist::Serializer:        2.0 i/s - 1.02x  slower
#   AMS (associations): collection:        1.3 i/s - 1.52x  slower

# Conflicts: # README.md

nesaulov added 2 commits January 27, 2018 00:35

Some optimizations: remove kwargs due to performance issues

d96db5b

[#40] Add initial benchmarks

189baea

nesaulov changed the title ~~1.0.0 release~~ [WIP] 1.0.0 release Jan 26, 2018

nesaulov requested a review from AlessandroMinali January 26, 2018 21:43

nesaulov added refactoring WIP labels Jan 26, 2018

nesaulov added this to the 1.0.0 milestone Jan 26, 2018

houndci-bot reviewed Jan 27, 2018

View reviewed changes

nesaulov added 4 commits January 27, 2018 17:12

Add dynamically built and included module that holds methods from jso…

fd36e72

…n_schema for classes that inherit from Surrealist::Serializer

Add benchmarks for AMS logger turned on/off

575d8d5

👮

ac52ab9

👮

cdd1226

Repository owner deleted a comment from houndci-bot Jan 27, 2018

Extract benchmarks into methods

9941dce

nesaulov added 4 commits January 30, 2018 23:47

Add benchmarks for associations

88b8d7c

Add ORMs section to README

14809f6

Fix typos

67dd73d

Update roadmap

9054a65

Performance improvements

ecf36d4

nesaulov added 3 commits February 3, 2018 19:00

Update benchmark results

e85c2a8

Merge branch 'master' into 1_0_0

ca44068

# Conflicts: # README.md

Merge branch 'master' into 1_0_0

b133c97

Merge branch 'master' into 1_0_0

8dcfb4c

AlessandroMinali approved these changes Feb 7, 2018

View reviewed changes

nesaulov added 3 commits February 8, 2018 08:46

Merge branch 'master' into 1_0_0

3ae3491

Update benchmark results

813652d

Update CHANGELOG & README

61cdcd3

nesaulov merged commit a96ea50 into master Feb 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] 1.0.0 release #64

[WIP] 1.0.0 release #64

nesaulov commented Jan 26, 2018 •

edited

Loading

nesaulov commented Jan 26, 2018 •

edited

Loading

houndci-bot Jan 27, 2018

houndci-bot Jan 27, 2018

nesaulov commented Jan 30, 2018

nesaulov commented Feb 3, 2018

nesaulov commented Feb 3, 2018

nesaulov commented Feb 3, 2018

		x.compare!
		end

		x.compare!
		end

[WIP] 1.0.0 release #64

[WIP] 1.0.0 release #64

Conversation

nesaulov commented Jan 26, 2018 • edited Loading

nesaulov commented Jan 26, 2018 • edited Loading

houndci-bot Jan 27, 2018

Choose a reason for hiding this comment

houndci-bot Jan 27, 2018

Choose a reason for hiding this comment

nesaulov commented Jan 30, 2018

nesaulov commented Feb 3, 2018

nesaulov commented Feb 3, 2018

nesaulov commented Feb 3, 2018

nesaulov commented Jan 26, 2018 •

edited

Loading

nesaulov commented Jan 26, 2018 •

edited

Loading