Improve the Zig template #1974
Merged
Improve the Zig template #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
Jul 2, 2022
| @@ -269,7 +269,7 @@ pub const trib = raw.trib; | |||
|
|
|||
| const TextriArgs = struct { | |||
| texture_source : TextureSource = TextureSource.TILES, | |||
| transparent: []const u8 = .{}, | |||
| transparent: []const u8 = &.{}, | |||
There was a problem hiding this comment.
This is a bit strange, what version of Zig were you using again?
There was a problem hiding this comment.
Just the latest master, since 0.9.1 is missing the export_table field on LibExeObjStep.
Without the &, it seems to be an array literal (type omitted), which can't be coerced to a slice. The pointer to the array can be coerced though. (Zig Documentation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1784 (comment), I found a few problems with the current Zig template.
With this PR, there is no longer an example of using the raw API, as I couldn't come up with a suitable structure that supported multiple examples without duplicating tic80.zig. I don't think this is a major issue though, as I imagine most users of the WASM templates will use the wrappers anyway.