- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
janet support #2079
Merged
Merged
janet support #2079
+1,545
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They REALLY should mention janet_resolve() in Janet's docs
Turns out there actually was a bug in Janet's compiler, which was responsible for making Janet panic in a scenario where it shouldn't have
To the people watching this PR, I think I'm going to need some assistance with the failing builds.
any help or points in the right direction would greatly appreciated, as I'm pretty stumped.. |
With the help of the great people over in the janet Gitter chat, all platforms builds are now passing! I've marked this PR as ready for review |
nesbox
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possible replacement for #2069, builds off the work of @dressupgeekout. All functions bindings are complete, things left to do:
(import tic80)
or(use tic80)
. This is to avoid function name collisions ofprint
andmap