Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Python a configurable build option. #2422

Closed
wants to merge 1 commit into from
Closed

Make Python a configurable build option. #2422

wants to merge 1 commit into from

Conversation

Wang-Yue
Copy link
Contributor

No description provided.

nesbox
nesbox requested changes Dec 26, 2023
View reviewed changes
Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I just split the CMakeFiles.txt into submodules here #2421 and now we have conflicts. Could you pls resolve it?
Thanks

@Wang-Yue
Copy link
Contributor Author

Unfortunately, I just split the CMakeFiles.txt into submodules here #2421 and now we have conflicts. Could you pls resolve it? Thanks

No problem. I can fix the merge conflict tomorrow.

@nesbox
Copy link
Owner

nesbox commented Dec 26, 2023

I added your changes in my commit 4a8cd41
so I'll close this PR
thank you for the help

@nesbox nesbox closed this Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesbox nesbox nesbox requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wang-Yue @nesbox