Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise test_rdv_param_setting to detect missing generators and check numbers. #349

Closed
jougs opened this issue May 18, 2016 · 0 comments · Fixed by #1549
Closed

Revise test_rdv_param_setting to detect missing generators and check numbers. #349

jougs opened this issue May 18, 2016 · 0 comments · Fixed by #1549
Assignees
@heplesser
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Milestone
NEST 3.0

Comments

@jougs
Copy link
Contributor

jougs commented May 18, 2016

Currently, anyone implementing a new RDV has to add a parameter-setting test to test_rdv_param_setting.sli. This may be forgotten. One should put all test setup into an array, so one can check that tests are available for all generators in rdevdict.

In addition, where numbers are generated, one may also check for upper and lower bounds and data type (double vs long).

This was known as trac829.
@heplesser heplesser added ZC: Kernel DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: Pending DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Jun 29, 2017
@heplesser heplesser self-assigned this Jun 29, 2017
@heplesser heplesser assigned jougs and unassigned heplesser Sep 13, 2018
@heplesser heplesser added this to the NEST 3.0 milestone Sep 13, 2018
@heplesser heplesser mentioned this issue Feb 21, 2020
Closed
@heplesser heplesser assigned heplesser and unassigned jougs Apr 20, 2020
@hakonsbm hakonsbm mentioned this issue Apr 24, 2020
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heplesser heplesser

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Projects
None yet
Milestone
NEST 3.0
Development

Successfully merging a pull request may close this issue.

Modernize random number generator setup hakonsbm/nest-simulator
2 participants
@heplesser @jougs