-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to allow installation with Python 3.8 #1340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes #1337. |
heplesser
requested changes
Nov 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steffengraber Thank you for the fix! I have a few small comments in the code.
heplesser
approved these changes
Nov 24, 2019
jougs
approved these changes
Nov 24, 2019
AliceGem
added a commit
to dbbs-lab/bsb-daint
that referenced
this pull request
Sep 15, 2020
2.18.0 compatible with Python 3.8 nest/nest-simulator#1340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
S: Normal
Handle this with default priority
T: Maintenance
Work to keep up the quality of the code and documentation.
ZC: PyNEST
DO NOT USE THIS LABEL
ZP: PR Created
DO NOT USE THIS LABEL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to allow installation with python 3.8.
After building NEST with python 3.8, an
import nest
returnsthe following error.
There is a further explanation here:
https://bugs.python.org/issue35894