Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix input ports #947

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Fix input ports #947

merged 5 commits into from
Sep 13, 2023

Conversation

pnbabu
Copy link
Contributor

@pnbabu pnbabu commented Aug 31, 2023

This PR fixes the following:

  • a bug in the handle() function for negative weights.
  • a bug in the receptor_types dictionary in the neuron's get() which displayed incorrect receptor type ports.
  • improved the test for different kinds of input ports

@pnbabu pnbabu requested a review from clinssen August 31, 2023 10:46
clinssen
clinssen approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@clinssen clinssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@clinssen clinssen merged commit f8dbab7 into nest:master Sep 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnbabu @clinssen