Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix third factor STDP synapse test #956

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fix third factor STDP synapse test #956

merged 1 commit into from
Sep 15, 2023

Conversation

clinssen
Copy link
Contributor

No description provided.

@clinssen clinssen added the bug label Sep 15, 2023
@clinssen clinssen changed the title Fix triplet STDP test Fix third factor STDP synapse test Sep 15, 2023
pnbabu
pnbabu reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@pnbabu pnbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, expect that the test is failing for NEST 2.

pnbabu
pnbabu approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@pnbabu pnbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

@pnbabu pnbabu merged commit 4339780 into nest:master Sep 15, 2023
7 checks passed
clinssen added a commit that referenced this pull request Sep 16, 2023
@clinssen
Revert "fix third-factor STDP test condition (#956)"
0815e13 
This reverts commit 4339780.
@clinssen clinssen mentioned this pull request Sep 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnbabu pnbabu pnbabu approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clinssen @pnbabu