refactor: sets correct typing to inject property #1104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
inject
property atHttpModuleAsyncOptions
was typed asany[]
, causing some confusion.Issue Number: N/A
What is the new behavior?
The
inject
property atHttpModuleAsyncOptions
is now typed asInjectionToken
that was brought from nest core repository.Does this PR introduce a breaking change?
Other information
I would also like to suggest adding a section to the module's documentation page about injecting standalone providers since only registering them at
extraProviders
is not enough. As soon and if this type refactor is merged I will myself open another pr updating the docs.