Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sets correct typing to inject property #1104

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

ivanzigoni
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

The inject property at HttpModuleAsyncOptions was typed as any[], causing some confusion.

Issue Number: N/A

What is the new behavior?

The inject property at HttpModuleAsyncOptions is now typed as InjectionToken that was brought from nest core repository.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I would also like to suggest adding a section to the module's documentation page about injecting standalone providers since only registering them at extraProviders is not enough. As soon and if this type refactor is merged I will myself open another pr updating the docs.

@kamilmysliwiec kamilmysliwiec added the enhancement New feature or request label Oct 21, 2024
@kamilmysliwiec kamilmysliwiec merged commit faf41c7 into nestjs:master Oct 21, 2024
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants