Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clone axios args and req config #1232 #1234

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

trochol
Copy link

@trochol trochol commented Oct 28, 2024

With this fix the given req config will be extended with a cancel token on each subscription. This ensures that a retry without an immediate cancel is possible.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1232

What is the new behavior?

With this fix the given req config will be extended with a cancel token on each subscription.
This ensures that a retry without an immediate cancel is possible.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

With this fix the given req config will be extended with a cancel token on each subscription.
This ensures that a retry without an immediate cancel is possible.
@kamilmysliwiec kamilmysliwiec added the bug Something isn't working label Oct 29, 2024
@kamilmysliwiec kamilmysliwiec merged commit 375e601 into nestjs:master Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants