refactor(utils): generate unique id only when needed #915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
uuidv4()
is being called even if it's not used.What is the new behavior?
Inlines the
uuid()
call to rely on JS short circuit on OR operation to generate the uuid v4 only if the factory key was not provided. Thefactory.KEY
will always be defined for those that are usingregisterAs
, thus they can avoid the computation ofuuidv4()
Does this PR introduce a breaking change?