feat: add ConfigService#getOrThrow() #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micalevisk
reviewed
May 14, 2022
micalevisk
reviewed
May 18, 2022
|
Great addition! |
|
@jonahsnider can you rebase your branch? go to your repo and click on Fetch upstream > Fetch and merge |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Users must either use full schema validation of configuration values or write their own
.getOrThrow()method.Issue Number: N/A
What is the new behavior?
ConfigService#getOrThrow()can be used to get a configuration value by key, and throw if it does not exist (and no default value was provided).Does this PR introduce a breaking change?
Other information
Relevant Discord conversation.