style(cqrs): fix typing for CommandHandler to actually accept the type of class extending ICommand #1206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I extended
ICommand
interface via TypeScript's Declaration Merging, adding own properties there, so that I can enforce all my commands to adhere to some standard format. This made my code not compile due to invalid/incomplete typing forCommandHandler
decorator, which expectsICommand
instance passed as an argument, while the documented intention is that it acceptsICommand
-compatible type.Issue Number: N/A
What is the new behavior?
I extended the existing typing so that the actual class type that implements
ICommand
is accepted byCommandHandler
decorator.Does this PR introduce a breaking change?
Other information