fix: Copy Icon is not restoring back from right tick ,when Copied #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,12 +14,20 @@ export class CopyButtonComponent { | |||
| public elRef = inject<ElementRef<HTMLElement>>(ElementRef<HTMLElement>); | |||
| public copied = false; | |||
|
|
|||
| onCopy() { | ||
| const preRef = this.elRef.nativeElement.querySelector('pre:not(.hide)'); | ||
| if (!preRef) { | ||
| return; | ||
| } | ||
| navigator.clipboard.writeText(preRef.firstChild.textContent); | ||
| this.copied = true; | ||
| this.cdr.detectChanges(); | ||
|
|
||
| setTimeout(() => { |
There was a problem hiding this comment.
Suggested change
| setTimeout(() => { | |
| this.revertIconTimeout = setTimeout(() => { |
There was a problem hiding this comment.
should we assign the result of the setTimeout call to a property and clearTimeout in the onDestroy lifecycle hook?
There was a problem hiding this comment.
I've implemented the suggested change, and it was a great idea—thank you!
aliahmadCode
force-pushed
the
copy_button_toggle
branch
from
05372f1 to
500a7c6
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3177
PR Type
Bug
What is the current behavior?
Currently, It is copying and then not restoring back to copy icon after some timeout
Issue Number: #3177
What is the new behavior?
Now, I have added the setTimeout to 2s to toggle back to copy icon.