Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Joi example to current version (16.*) by fixing deprecated Joi… #689

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

murbanowicz
Copy link
Contributor

….validate usage

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other... Please describe:

What is the current behavior?

Docs show example which is using deprecated Joi.validate() as per hapijs/joi#1941

What is the new behavior?

Docs show example with current way of usage which is calling validate() directly on schema.

@kamilmysliwiec
Copy link
Member

Thank you!

@kamilmysliwiec kamilmysliwiec merged commit 8a42fcd into nestjs:master Sep 23, 2019
@murbanowicz murbanowicz deleted the update-joi-example-to-v16 branch September 23, 2019 16:47
@murbanowicz
Copy link
Contributor Author

No problem! Thank you for great work on Nest :)

@kamilmysliwiec
Copy link
Member

❤️

duard pushed a commit to duard/docs.nestjs.com that referenced this pull request Apr 4, 2023
docs(pipes) update Joi example to current version (16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants