fix(@nestjs/graphql): set unique ids on resolvers to fix cache errors #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resolver metadata cache currently uses the resolver name for the key but this causes issues if we have two resolvers in different modules but with the same name and identical method signatures. For controllers, each controller gets a unique ID that is used as the key in the cache. Add code to set up unique IDs for resolvers as well so that cache retrieval is correct. Fixes nestjs#1907
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The resolver metadata cache currently uses the resolver name for the key as shown below
https://github.com/nestjs/nest/blob/39ec4cda7363aac3551ff0f1b83feb41ba2f0bf6/packages/core/helpers/handler-metadata-storage.ts#L60-L63
This causes issues if we have two resolvers in different modules but with the same name and identical method signatures. For controllers, each controller gets a unique ID that is used as the key in the cache as shown below:
https://github.com/nestjs/nest/blob/39ec4cda7363aac3551ff0f1b83feb41ba2f0bf6/packages/core/injector/module.ts#L461-L462
Add code to set up unique IDs for resolvers as well so that cache retrieval is correct.
Issue Number: #1907
What is the new behavior?
Each resolver gets a unique ID so that it can be retrieved correctly from the metadata cache. The solution re-uses the ID key that controllers also use so I worry that that may cause confusion.
Does this PR introduce a breaking change?