Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mercurius): add mercurius hooks #2546

Merged
merged 4 commits into from
Feb 7, 2023
Merged

feat(mercurius): add mercurius hooks #2546

merged 4 commits into from
Feb 7, 2023

Conversation

tugascript
Copy link
Contributor

@tugascript tugascript commented Dec 8, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

There is no way to add Mercurius Hooks into the Mercurius GraphQL Driver

What is the new behavior?

Adds an optional object with the possible hooks that can be added to mercurius.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@tugascript tugascript changed the title WIP feat(mercurius): add mercurius hooks feat(mercurius): add mercurius hooks Dec 9, 2022
@tugascript tugascript marked this pull request as ready for review December 9, 2022 23:17
@smolinari smolinari mentioned this pull request Dec 22, 2022
12 tasks
Copy link
Contributor

@Tony133 Tony133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is an interesting feature, I hope it will be added 🙌

@kamilmysliwiec
Copy link
Member

There's a bunch of new conflicts that arised after I merged your other PR @tugascript (plugins support) 😢

@tugascript
Copy link
Contributor Author

There's a bunch of new conflicts that arised after I merged your other PR @tugascript (plugins support) cry

Yeah I expected that, I will rebase the other PR to this one

@kamilmysliwiec
Copy link
Member

Note:

image

This test should be already fixed on master

@tugascript
Copy link
Contributor Author

Note:

image

This test should be already fixed on master

Yeah somewhere on the rebase the tests were not copied I am rebasing everything again :')

@tugascript
Copy link
Contributor Author

tugascript commented Feb 6, 2023

@kamilmysliwiec done rebasing could you double check if the tests are ok before merging, they seem in sink, but with rebasing twice, I can have weird behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants